Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit QueryEnhancer exception handling #2856

Open
mp911de opened this issue Mar 14, 2023 · 1 comment
Open

Revisit QueryEnhancer exception handling #2856

mp911de opened this issue Mar 14, 2023 · 1 comment
Labels
in: query-parser Everything related to parsing JPQL or SQL type: task A general task

Comments

@mp911de
Copy link
Member

mp911de commented Mar 14, 2023

For some queries (e.g. INSERT, UPDATE, DELETE), it doesn't make sense to derive count queries or apply sorting. We should throw proper exceptions instead of returning default values that do not make any sense.

@mp911de mp911de added type: task A general task in: query-parser Everything related to parsing JPQL or SQL labels Mar 14, 2023
@arefbehboudi
Copy link
Contributor

arefbehboudi commented Mar 30, 2024

@mp911de As a beginner in open-source contributions, do you think it's okay for me to start working on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: query-parser Everything related to parsing JPQL or SQL type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants