Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: add custom command line switches? (eg --network host) #87

Open
pataquets opened this issue Aug 11, 2024 · 2 comments
Open

RFC: add custom command line switches? (eg --network host) #87

pataquets opened this issue Aug 11, 2024 · 2 comments

Comments

@pataquets
Copy link
Contributor

This time, I need to add the --network host switch, and there's no specific defcustom.
However, given the long list of docker build command line switches, I'm wondering if some kind of dockerfile-build-extra-options kind of defcustom would be a better solution for more uncommon options.
Note that I'm not advocating against adding more specific and meaningful dockerfile-build-* options, which would be the best most of the times.
But having to think about an implementation and sending a PR is quite more involved and there's the risk of users "just hacking" the package. Specially if you need a switch temporarily or as a test, before you settle on using it more frequently and you're up to giving the switch some love with a PR.
@drewcsillag WDYT? Any advice/hint before sending the PR? (eg. defcustom name)

@drewcsillag
Copy link
Collaborator

Sorry for the delay! I like this idea. Better than having a zillion defcustoms for random things.

@pataquets
Copy link
Contributor Author

Happy to hear that, @drewcsillag.
I've just opened PR #88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants