-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group deletion #9
Comments
Hi @dmlls, glad you like the app :) About deletion, I assume you’re talking about actual deletion, not just removing it from the recent groups list? (Although that would be useful too). For now there is no mechanism in place to delete the groups, but that would be a nice feature. For automatic deletion, I guess I could implement something like deleting all data related to a group after one year without the group being accessed. The only concern I have is that (by design) there is no user account and no email address, therefore I can’t send any warning or reminder about group deletion… Maybe a warning when creating the group (and maybe in the settings) would be enough for the users to be careful about it. |
Yes, I was thinking about actual deletion, but I guess it would also make sense to remove the group from recents once it's removed.
This sounds sensible to me. Automatic deletion would probably also help you keep the database a bit tidier :) |
Perhaps some kind of warning icon/note near a group to indicate it "will be auto-deleted soon"? |
But there is no authentication. If someone randomly opens a group, can delete a lot of data which might not be intended. |
@neonshobhit If a malicious actor gets access to a group, the group is pretty much "done", with or without this feature (e.g. they could simply delete all transactions or edit them maliciously). In order to mitigate brute force attacks, group ids are generated randomly, contain letters, numbers and symbols, and are long enough. It's basically like trying to brute force a password. If hypothetically they still got the group id by other means, what @manuerwin proposed in #9 (comment) would also mitigate malicious deletions, since the legitimate group members could revert the deletion before it's completed. Furthermore, if #34 gets implemented, the group members could then set a password for the group to make sure the malicious actors can no longer access it (or change the password, in case they had previously set it). |
Not exactly like trying to brute force a password. Passwords are hashes of a string generally. If any character mismatches, you can't access particular password.
Sure, #34 works. Just that sharing passwords in urls can still be logged somewhere or malicious people can read it over the network. Blast radius will be very small though. If this is a calculated risk we are okay taking, I can resolve #34 after I'll be done with #5. |
Deleting groups, and auto-deleting after one year of inactivity are both reasonable features. I just learned about Spliit and created a couple test groups just to try it out. I'm sure a significant portion of all the groups in the database at spliit.app are just tests. :) |
I think some feature like this would be required for spliit to be GDPR-compliant. |
HI, first of all, thanks for this app, I've been using it for a while and works great!
I have two questions related to group deletion:
The text was updated successfully, but these errors were encountered: