ci: Update caching mechanism and refactor the actions #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mossaka
requested review from
kate-goldenring,
jsturtevant,
radu-matei and
devigned
as code owners
Mossaka
changed the title
Mossaka
changed the title
Mossaka
changed the title
Mossaka
force-pushed
the
mossaka/setup-rust
branch
from
af06740 to
ae45b36
Compare
Mossaka
force-pushed
the
mossaka/setup-rust
branch
from
ae45b36 to
19eecaf
Compare
|
It looks like the build still takes 27+ mins? |
… key Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
1. Renamed workflows to follow a consistent naming convention (`action-*`) 2. Extracted reusable workflows Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Mossaka
force-pushed
the
mossaka/setup-rust
branch
from
19eecaf to
febdfb1
Compare
umm let me check what's going on. The previous run succeeded in 1m 41s: https://github.com/spinkube/containerd-shim-spin/actions/runs/12360411165/job/34497376173?pr=248 |
|
Okay I ru-ran the CI and this time the build finishes in 1m 44s: https://github.com/spinkube/containerd-shim-spin/actions/runs/12822111054/job/35754491970?pr=248 |
jsturtevant
reviewed
Jan 17, 2025
| publish-node-installer-image: | ||
| uses: ./.github/workflows/node-installer.yaml | ||
| uses: ./.github/workflows/action-node-installer.yaml | ||
| needs: build | ||
| # This action requires use of the GITHUB_TOKEN to publish the image | ||
| # By default, PRs from forks don't have access, so we only run when the PR branch is on origin. |
There was a problem hiding this comment.
It looks like this ran on the PR. Is that expected? From the comment it sounds like it shouldn't on forks?
There was a problem hiding this comment.
oh looks like your branch is on the upstream repo here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that our CI isn't caching the build artifacts and thus each build takes more than 20 minutes to build and test. This is an attempt to cache the successful build in GitHub.
This PR also reorganizes the GitHub Action files and renamed a bunch of symbols to keey a consistent style.