-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Publish examples as Spin apps #161
Comments
Last I tried, I believe Docker Desktop and Rancher does not support that format, but only the Docker images format at this point. |
+1 to @mikkelhegn comment. However, I'd like to publish the images to the standardized format when Docker Desktop and Rancher support them. |
Thank you @mikkelhegn and @Mossaka. Ok, for now, we should publish the examples as Spin apps in addition to their current Docker image forms. Next question: naming. The current Docker image references have names like |
yeah I like the addition of category names to images. 👍 for me |
The example apps in this repo are still published as stock Docker images: https://github.com/spinkube/containerd-shim-spin/blob/main/.github/workflows/docker-build-push.yaml
We should publish as Spin apps via
spin registry push
directly, so that they can be also be run via egspin up -f <ref>
.One question:
Do we still want to publish these examples as apps wrapped in Docker image form? Or would we like to fully switch to publishing solely viaYes, as answered below, we need to keep publishing as Docker images.spin registry push
?The text was updated successfully, but these errors were encountered: