Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring sparse_hash_map::emplace's helper functions #49

Open
brandonfoong opened this issue Jul 4, 2022 · 1 comment · May be fixed by #50
Open

Refactoring sparse_hash_map::emplace's helper functions #49

brandonfoong opened this issue Jul 4, 2022 · 1 comment · May be fixed by #50

Comments

@brandonfoong
Copy link
Contributor

Thanks for merging #48.

In order to minimize the changes made, I implemented the helper functions (emplace_at, emplace_noresize, set_inplace) separately from the existing helper functions for insert (insert_at, insert_noresize, set).

However, dense_hash_map only has one set of helper functions (insert_...), which are used for both insert and emplace. Would it be ok for me to do something similar for sparse_hash_map (i.e. only keep 1 set of helper functions to avoid repetition)?

@PhilipDeegan
Copy link
Member

if you think it's better go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants