Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

batches: improve failure behaviour when uploading changeset and batch specs #30431

Open
LawnGnome opened this issue Jan 31, 2022 · 0 comments · May be fixed by sourcegraph/src-cli#705
Open

batches: improve failure behaviour when uploading changeset and batch specs #30431

LawnGnome opened this issue Jan 31, 2022 · 0 comments · May be fixed by sourcegraph/src-cli#705
Labels
batch-changes Issues related to Batch Changes

Comments

@LawnGnome
Copy link
Contributor

One problem that we've now seen from multiple users is that uploading changeset and batch specs after batch change execution is fragile — since there are n+1 uploads, any load issue on the Sourcegraph instance or network blip beyond what a single HTTP request can handle is problematic.

We should either implement some basic retry/backoff logic in src, or provide an omnibus (streaming?) upload endpoint. Or both.

@LawnGnome LawnGnome added the batch-changes Issues related to Batch Changes label Jan 31, 2022
LawnGnome referenced this issue in sourcegraph/src-cli Mar 2, 2022
Fixes sourcegraph/sourcegraph#30431.
LawnGnome referenced this issue in sourcegraph/src-cli Mar 2, 2022
Fixes sourcegraph/sourcegraph#30431.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
batch-changes Issues related to Batch Changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants