Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check blocks are present during backup #130

Open
sourcefrog opened this issue Jun 21, 2020 · 0 comments
Open

Check blocks are present during backup #130

sourcefrog opened this issue Jun 21, 2020 · 0 comments

Comments

@sourcefrog
Copy link
Owner

sourcefrog commented Jun 21, 2020

a21737b changed Conserve so that it assumes that blocks referenced by previous indexes are present in the archive. That helps performance, but it does mean that blocks that are missing in the previous band will never get re-added by a later band: the files just remain missing, which is not great.

Perhaps this should be reverted, and instead Conserve should check the blocks are present before adding a new reference to them, perhaps with an in-memory cache of which ones have been seen. #106

If the previous index references an out-of-range address that won't be caught, but perhaps that's less likely: it requires a bug in the old version, not just loss of files.

Another possibility: add a --thorough option that could:

  1. Always read the content of files, rather than checking their timestamp.
  2. Always check the blocks are present, rather than assuming referenced blocks are present.

However, perhaps this puts the work on the user to run validate and interpret the results, and it might be better to just do the right thing without supervision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant