Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that fitted parameters are as expected #7

Open
taldcroft opened this issue Apr 27, 2017 · 0 comments
Open

Test that fitted parameters are as expected #7

taldcroft opened this issue Apr 27, 2017 · 0 comments

Comments

@taldcroft
Copy link
Member

It would be good in the regression test to explicitly confirm that the new fitted parameters agree with expectation, not just that the fit improved. This should be the case to at least 3 digits, probably more (e.g. use np.allclose(.., rtol=0, atol=1e-3)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taldcroft