Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging for get_cmds should use populated times #324

Open
jeanconn opened this issue Feb 26, 2024 · 1 comment
Open

Logging for get_cmds should use populated times #324

jeanconn opened this issue Feb 26, 2024 · 1 comment

Comments

@jeanconn
Copy link
Contributor

I'm seeing

In [5]: obs = kadi.commands.observations.get_observations(obsid=47350)
2024-02-26 12:34:51,965 get_cmds: Getting commands from 2024:057:17:34:51.965 to 2024:057:17:34:51.965 for scenario=None

And that time range isn't helpful. It looks like the logger should log out what time range it is using after None values have been populated.

f"Getting commands from {CxoTime(start).date} to {CxoTime(stop).date} for {scenario=}"

@jeanconn
Copy link
Contributor Author

Granted, it looks like the standard behavior is just to get everything anyway, so a better log message here probably wouldn't help anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant