From 83e514a9e7731742a00df2c4f546909c63970514 Mon Sep 17 00:00:00 2001 From: Ryo Onodera Date: Thu, 29 Feb 2024 00:24:49 +0900 Subject: [PATCH] Use the From trait for PageUsage --- unified-scheduler-logic/src/lib.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/unified-scheduler-logic/src/lib.rs b/unified-scheduler-logic/src/lib.rs index 9055438eed63e0..77165708922395 100644 --- a/unified-scheduler-logic/src/lib.rs +++ b/unified-scheduler-logic/src/lib.rs @@ -384,8 +384,8 @@ enum PageUsage { } const_assert_eq!(mem::size_of::(), 8); -impl PageUsage { - fn from_requested_usage(requested_usage: RequestedUsage) -> Self { +impl From for PageUsage { + fn from(requested_usage: RequestedUsage) -> Self { match requested_usage { RequestedUsage::Readonly => PageUsage::Readonly(ShortCounter::one()), RequestedUsage::Writable => PageUsage::Writable, @@ -561,7 +561,7 @@ impl SchedulingStateMachine { fn try_lock_page(page: &PageInner, requested_usage: RequestedUsage) -> LockResult { match page.usage { - PageUsage::Unused => LockResult::Ok(PageUsage::from_requested_usage(requested_usage)), + PageUsage::Unused => LockResult::Ok(PageUsage::from(requested_usage)), PageUsage::Readonly(count) => match requested_usage { RequestedUsage::Readonly => LockResult::Ok(PageUsage::Readonly(count.increment())), RequestedUsage::Writable => LockResult::Err(()),