Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy requires a Solana.toml #26

Open
nickfrosty opened this issue Jan 16, 2025 · 1 comment
Open

deploy requires a Solana.toml #26

nickfrosty opened this issue Jan 16, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@nickfrosty
Copy link
Member

currently, the deploy command requires a Solana.toml to exist.
while the toml file can make things easier for mucho to parse, developers should not be forced to create and use one

i consider this a bug.

@nickfrosty nickfrosty added the bug Something isn't working label Jan 16, 2025
@arrayappy
Copy link
Contributor

Tested that deploy command works without Solana.toml as well. However, it currently breaks if Solana.toml exists but doesn't have entries for the current program/cluster.

Suggestion: We could improve this further by making Solana.toml entirely optional, where:

  • If it exists, use it as a convenient way to specify program IDs and settings
  • If it doesn't exist or doesn't have entries for current program/cluster, fall back to auto-detection

This would give flexibility while maintaining the convenience of using toml when desired.

Would you like me to create a PR with these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants