Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback Lab 2 #4

Open
hdmeyer opened this issue Sep 25, 2017 · 0 comments
Open

Feedback Lab 2 #4

hdmeyer opened this issue Sep 25, 2017 · 0 comments

Comments

@hdmeyer
Copy link

hdmeyer commented Sep 25, 2017 •
edited
Loading

Group # Exercise 1 Comments Exercise 2 Comments Exercise 3 Comments Exercise 4 Comments Exercise 5 Comments Exercise 6 Comments Exercise 7 Comments Exercise 8 Comments Total
4 9 Good solution: no timing 9 Good solution: no timing 4 -> Issues 6 Test report and time missing.What does testNotPermutationSingle? 4 isPermutation is wrong. Why not using isPermutation of 4? 7 Why the argument n in shift if elsewhere 26 is already hardcoded. No specification but a lot of interesting tests 8 Good Implementation, but lacks of time reporting and more extensive testing 0   6.71
-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hdmeyer