-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
location.human_address is String -- not Hashie::Mash #14
Comments
@marks I love this idea. I've already been thinking about adding some "demarshalling" functionality to the Ruby gem, to do things like convert timestamps into Time objects, decode numerics, etc. One thing to be concerned about will be backwards compatibility. Thoughts? |
@chrismetcalf - didnt even realize dates were Strings - yes, we need demarshalling. How do you feel about tackling backwards compatibility by having it as an opt-in feature only by defining a config variable? |
I’m all for making it controlled by a config variable. If you’ve got the time to take this on, I’ll gladly give feedback and accept your PR! It might be worth checking out the datatype reference too: http://dev.socrata.com/docs/datatypes/ On Tue, Sep 9, 2014 at 5:19 PM, Mark Silverberg [email protected]
|
Just to keep everyone updated, I am trying to see if this makes more sense to build into Hashie which soda-ruby uses: hashie/hashie#227 |
Is this on purpose or would a PR to convert location fields' human_address in to hashes be accepted?
Right now, we are looping through all returned records to convert the location into a hash like so:
The text was updated successfully, but these errors were encountered: