Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define os.File adapter #3

Closed
plastikfan opened this issue Oct 15, 2024 · 1 comment · Fixed by #37
Closed

define os.File adapter #3

plastikfan opened this issue Oct 15, 2024 · 1 comment · Fixed by #37
Assignees
@plastikfan
Labels
feature New feature or request

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Oct 15, 2024 •
edited
Loading

To get arounf the problem of os.File is a struct and not an interface, which poses a problem for fstest.MapFS which uses it own FIle abstraction, MapFile.
@plastikfan plastikfan added the feature New feature or request label Oct 15, 2024
@plastikfan plastikfan self-assigned this Oct 15, 2024
@plastikfan plastikfan mentioned this issue Oct 15, 2024
Closed
@plastikfan plastikfan changed the title define file interface feature define file interface Oct 17, 2024
@plastikfan plastikfan changed the title define file interface define os.File adapter Oct 25, 2024
@plastikfan
Copy link
Contributor Author

Actually, the fix for this is to use fs.File, which IS an interface, so the file system interfaces have all been changed to use fs.File instead of *os.File.

plastikfan added a commit that referenced this issue Oct 25, 2024
@plastikfan
ref(luna): use fs.File interface with file systems (#3)
c5129b4
@plastikfan plastikfan linked a pull request Oct 25, 2024 that will close this issue
ref(luna): use fs.File interface with file systems (#3) #37
Merged
plastikfan added a commit that referenced this issue Oct 25, 2024
@plastikfan
ref(luna): use fs.File interface with file systems (#3)
6176253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plastikfan plastikfan

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(luna): use fs.File interface with file systems (#3) snivilised/nefilim
1 participant
@plastikfan