Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fork from settingsContext.ts #184

Open
thevaizman opened this issue Oct 21, 2022 · 0 comments
Open

Remove fork from settingsContext.ts #184

thevaizman opened this issue Oct 21, 2022 · 0 comments
Labels
improvement Improvement

Comments

@thevaizman
Copy link
Contributor

thevaizman commented Oct 21, 2022

Currently, we save the user settings in the browser's localStorage.
These settings include:

export enum Setting {
  EditorCodeType = 'editor::codetype',
  VmChain = 'vm::chain',
  VmFork = 'vm::fork',
}

We should consider removing VmFork from here since this is somewhat a weird behavior. I'd imagine users would rather be on the latest fork by default instead of staying "stuck" on the last fork they manually chose.

@thevaizman thevaizman added the improvement Improvement label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement
Projects
None yet
Development

No branches or pull requests

1 participant