-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hmr requires symmetric data, fails on lifted over .meth files #43
Comments
Hmm I think my filtering script is not doing a good job of actually removing "symmetric looking" sites. Trying to figure out a way to deal with them. Why is it necessary for |
The sites need to be CpG sites, or the concept of HMRs wouldn't apply. But you are correct that in theory they don't need to be "symmetric" in the file anymore. There's now only a historical artifactual reason that check exists. But I can't just disable it completely right now. If you can build the tools from source, I can probably make a branch relatively quickly that disables that particular check. Also, if you could point me to any public data sets that are sufficiently similar to your own, I could test it myself. Either way, we can find out if it even makes sense to do that analysis on your data. |
Thanks, I can probably build from source if you make a test branch. The sites are definitely CpG only. That's the only ones I called from the original sequencing run. |
@faulk-lab I just made a branch |
@faulk-lab @moqri I'm adding information here from another issue opened on the same topic: Describe the bug To Reproduce However, running hmr-rep with two identical copies of the processed data works fine! Expected behavior Thanks for the great work! |
I have perhaps an unusual use case. I am using whole genome methylation data from multiple closely related vertebrates. In order to compare apples-to-apples, I need a common coordinate system so I lifted them all over to human hg38. Now I want to run them through hmr (and dmr and several other of your wonderful tools!). However hmr is complaining that
error: input is not symmetric-CpGs:
.My data is inherently symmetric because I specified merged symmetric coverage when I generated the bed file (that I converted to .meth with an awk script). My original data is from nanopore, and counts generated with
modkit
. It was direct methylation calling, not bisulfite, but once it has been converted to .meth format, I figured it didn't matter anymore.Anyway,
dnmtools hmr monkey.meth
works fine, but after I lift it over to hg38, and filtered the lines withdnmtools liftfilter
I trieddnmtools hmr monkey.hg38.meth
and it fails with the symmetric problem. I wrote a script to remove any lines that "looked symmetric" and still no joy. Ideas?The text was updated successfully, but these errors were encountered: