Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VS Classic] Implement status bar #8

Open
olegklimov opened this issue Nov 21, 2023 · 10 comments
Open

[VS Classic] Implement status bar #8

olegklimov opened this issue Nov 21, 2023 · 10 comments
Assignees

Comments

@olegklimov
Copy link
Contributor

It needs to show:

  • "|{ Refact" when idle
  • rotating icon of some sort when it's thinking about the new completion
  • contrast background and "unplugged" icon when error, tooltip should show what the error was
@olegklimov olegklimov changed the title Implement status bar [VS Classic] Implement status bar Nov 21, 2023
@olegklimov olegklimov mentioned this issue Nov 28, 2023
@digital-phoenix
Copy link
Contributor

@olegklimov can you elaborate on when it should show the unplugged icon and when it should show an error?

@digital-phoenix
Copy link
Contributor

@olegklimov or did you just mean that the unplugged icon should visually stand out

@olegklimov
Copy link
Contributor Author

@digital-phoenix unplugged is just this:

image

And this:

image

Give the LSP server a wrong address or something, you'll see an error. Or turn off Wi-Fi on your laptop.

@digital-phoenix
Copy link
Contributor

@olegklimov do you have an image I could use for "|{ Refact" or the disconnected plug icon?

@olegklimov
Copy link
Contributor Author

Almost! We need to give you @digital-phoenix a rotating icon. And a disconnected plug.

@hazratisulton
Copy link

hazratisulton commented Jan 29, 2024

no status popup, no icon changes when hovering;
no error message if you delete api key, close settings, open settings and add new incorrect key - still working;
no error message when change correct url to incorrect;
if no API key there is message "500 Internal Server error, no caps available" instead of "Missing authorization header";
incorrect message "The API key is not recognized" when API key is incorrect;
need to reload IDE when added correct API key;
If an error occurred previously, after it disappears, the error is still displayed in the pop-up window when hovering

@olegklimov
Copy link
Contributor Author

image

My list of unfinished things:

  • Popup that says which model was last used
  • Error message in the same popup, error icon, maybe error background in status bar
  • Errors that should make it into the popup (and icon): any LSP errors (give it a misspelled model), connection problems (turn wifi off), bad API key (especially important for the message to be intelligible).
  • If the API key is empty, popup should give a link to README on github to the #installation header, so people know what they need to do to make it work

@digital-phoenix
Copy link
Contributor

@olegklimov currently an error message is displayed as a tooltip if you mouse over the statusbar. Do you want the tool tip window to popup automatically when an error first happens?

@olegklimov
Copy link
Contributor Author

No, it's too intrusive. Background and icon change are good ideas. But not a popup that might be annoying.

@guptadeepak8
Copy link

@olegklimov i think the rotating icon is working what else need to be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants