Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion doesn't start after "pause refact" #7

Closed
hazratisulton opened this issue Feb 14, 2024 · 4 comments
Closed

Completion doesn't start after "pause refact" #7

hazratisulton opened this issue Feb 14, 2024 · 4 comments

Comments

@hazratisulton
Copy link

hazratisulton commented Feb 14, 2024

Steps to reproduce:
Checking completion - completion is working
Press "pause refact" (in Tools menu) and check - completion is not working (OK)
Press pause again - check completion.

Expected result:
Completion started and working.

Actual result:
Completion not working.
No error messages.
In console:

reloading settings Packages/User/refact.sublime-settings
reloading settings Packages/User/refact.sublime-settings

Additional info:
If you restart sublime, completion still won't work. If then press "pause refact", console will display the following:
Traceback (most recent call last): File "/snap/sublime-text/156/opt/sublime_text/Lib/python38/sublime_plugin.py", line 1704, in run_ return self.run(edit) File "/home/fupfv/.config/sublime-text/Packages/refact/__init__.py", line 128, in run refact_session_manager.get_session(self.view).clear_completion() AttributeError: 'NoneType' object has no attribute 'get_session' reloading settings Packages/User/refact.sublime-settings
If you manually change "pause_completion" setting to false in .config/sublime-text/Packages/User/refact.sublime-settings, completion will work.

Versions:
Refact 0.0.1
Sublime Text? Build 4169

@olegklimov
Copy link
Contributor

  1. Pause should be a command accessible in .sublime-keymap:
{
 { "keys": ["super+p"], "command": "refact_pause" },
}
  1. Documented in README
  2. Icon should be different in the status bar, like ⏸️

@olegklimov
Copy link
Contributor

Pause problem: I see Sublime Text/Packages/User/refact.sublime-settings:

{
        "pause_completion": true,
}

my settings are in Sublime Text/Packages/refact/refact.sublime-settings. I suspect the file in User replaces all my settings from the file in Packages/refact, including all the settings that make the plugin work.

@hazratisulton
Copy link
Author

hazratisulton commented Mar 4, 2024

Update:
Tested #16
Completion starts after "pause refact - OK.

  1. Pause should be a command accessible in .sublime-keymap:

I see the settings in the commit, but I don’t see them in the sublime when I open Key Bindings

  1. Documented in README

No information about key-bindings settings name.

  1. Icon should be different in the status bar

The pause icon appears immediately after pausing, but then error icon is displayed
Screencast from 09-03-24 17:48:47.webm

@hazratisulton
Copy link
Author

Checked #16 - completion and pause icon working,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants