Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Nub all evaluated list values? #44

Open
garyb opened this issue Sep 25, 2015 · 5 comments
Open

Nub all evaluated list values? #44

garyb opened this issue Sep 25, 2015 · 5 comments

Comments

@garyb
Copy link
Member

garyb commented Sep 25, 2015

Similar to #43, it might be better if we take care of de-duplicating values in the markdown itself, as having duplicate checkboxes, radio buttons or dropdown elements makes little sense and may even cause issues.

@garyb garyb changed the title Nub all list values values? Nub all list values? Sep 25, 2015
@garyb garyb changed the title Nub all list values? Nub all evaluated list values? Sep 25, 2015
@jonsterling
Copy link
Contributor

I would be in favor of this unless someone can find a problem with the idea... I got very confused this morning as a result of the current behavior.

@garyb
Copy link
Member Author

garyb commented Feb 19, 2016

I don't think there's a technical reason why we can't, but I would say a query populating one of these lists "should" use DISTINCT perhaps, in our case, so I wasn't sure whether we wanted to do it in the front end or not.

The only downside I can see is that doing so may hide poorly performing queries (a result set with 100,000 rows but only 2 unique values, that kind of thing).

@jonsterling
Copy link
Contributor

Hmm, that's a good point about DISTINCT.

@jdegoes
Copy link
Contributor

jdegoes commented Feb 19, 2016

Just on principle, I'd say it's best to avoid duplicating functionality (although the point about the elements requiring uniqueness is valid and worth consideration). On more pragmatic grounds, you'd have to implement an Eq for the Quasar's data model, which is not that simple to do, nor spec'd out because it's currently connector-dependent.

@jonsterling
Copy link
Contributor

@jdegoes Good point; regarding Eq, at this level, we just have strings in fact, so we can definitely compare them—but it may not be a good idea to do so 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants