Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currently this is only being used by BAX modules. #44

Open
github-actions bot opened this issue Nov 19, 2022 · 0 comments
Open

currently this is only being used by BAX modules. #44

github-actions bot opened this issue Nov 19, 2022 · 0 comments
Labels
enhancement New feature or request todo

Comments

@github-actions
Copy link

Need to remove all optimization/injector config methods from pyemittance

and make separate optimization module for BAX or integrate with Badger

# TODO: currently this is only being used by BAX modules.

            self.config_name = config_name
            self.config_dict = config_dict if config_dict else self.load_config()

        # Measurement quad info
        self.meas_pv_info = self.config_dict['meas_pv_info']
        self.meas_read_pv = PV(self.meas_pv_info['meas_device']['pv']['read'])
        self.meas_cntrl_pv = PV(self.meas_pv_info['meas_device']['pv']['cntrl'])

        # Load info about injector settings to optimize
        # TODO: currently this is only being used by BAX modules.
        # Need to remove all optimization/injector config methods from pyemittance
        # and make separate optimization module for BAX or integrate with Badger
        self.opt_pv_info = self.config_dict['opt_pv_info']
        self.opt_pvs = self.opt_pv_info['opt_vars']
        self.sol_cntrl_pv = PV(self.opt_pvs[0])
        self.cq_cntrl_pv = PV(self.opt_pvs[1])
        self.sq_cntrl_pv = PV(self.opt_pvs[2])
@github-actions github-actions bot added the todo label Nov 19, 2022
@pluflou pluflou added the enhancement New feature or request label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request todo
Projects
None yet
Development

No branches or pull requests

1 participant