Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing StylesReducer #28

Open
Vivek205 opened this issue Jul 15, 2019 · 0 comments
Open

Removing StylesReducer #28

Vivek205 opened this issue Jul 15, 2019 · 0 comments

Comments

@Vivek205
Copy link
Contributor

Looks like this is maintaining the visibility state of hamburger menu. You could rename the reducer accordingly. The reducer could be called something like mobileMenuReducer or something similar. The state could be visible instead of hamburgerMenu.

You will have to update the actions also accordingly.
On a second thought the problem should be solved using media queries rather than using redux.

comment
raamb added a commit that referenced this issue Sep 23, 2019
@raamb
Merge pull request #28 from singnet/master
1b966a1 
Pull fro parent
ramongduraes pushed a commit to ramongduraes/snet-dapp that referenced this issue Apr 10, 2020
@raamb
Merge pull request singnet#28 from raamb/master
9216778 
UX and bug fixes
ramongduraes pushed a commit to ramongduraes/snet-dapp that referenced this issue Apr 10, 2020
@raamb
Merge pull request singnet#28 from anandrgitnirman/master
3372a0a 
add the method componentWillReceiveProps across all servcies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vivek205