Unit defense percent should be drawn ABOVE the finger

[ghost]

At the current state of things, in order to be able to see the unit defense pct on a particular hex, on time of choosing where to move unit, I have to scroll the finger towards the lower or the upper quarter of the hex.

I would find nice if the defense pct was not fixed in the middle of the hex but flee the finger.

I even would find it nice to have it as an option for the desktop version too, defaulting to the classic behavior i.e. defense pct stays fixed in the middle of the hex.

Cheers and regards,

[singalen]

I was thinking the same, but didn't register it here. Thanks!

[singalen]

Found the code piece: game_display::draw_movement_info().
In fact, it's quite complicated to change.
I can draw defense rating on top of unit's route, but it's not guaranteed that it's the CURRENT route.
I wouldn't like to introduce mouse position dependence.

[singalen]

Found an acceptable way to do this. Coming soon!
Not doing it for a touchscreen PCs yet.

[ghost]

Got an e-mail a couple hours ago:

Battle for Wesnoth HD 1.13.10 (29) for iOS is ready to test

What To Test:

• Merged performance improvements from upstream.
• Fixed several crashes, attempted to fix even more.
• Draw defense rating above a finger when dragging a unit.
• Added "End turn for this unit" context menu item.
• OS Keyboard now works in in-game console and chat.
• Various fixes from upstream.

To test this app, open TestFlight on iPad using iOS 8.0 or later and install the update.

I just downloaded build 29. I am able to see "End turn for this unit" context menu item, but I'm having a bad time trying to have defense rating above a finger when dragging a unit. To my understanding, defense ratings are showing in the same way as in previous builds.

I guess it is expected. Reporting it, in case it is an oops.

Regards,

[singalen]

Thanks a lot! Indeed, very possible. Fixing.

[ghost]

Well done, thank you!

Couple comments, probably you know some, but to provide you completed feedback:

The new numbers, only the new numbers, not the previously existing numbers; sometimes appear to be twinkling, or not rendering at all, or rendering normally; over shallow water.

When ordering a multi turn move, the new number could be potentially rendered on top of a previously existing number that seems to be marking the unit's defense at the tile the unit will be holding at each turn after trying to approach its target with a part of the multi turn movement.

The top border of the map isn't resolved perfectly, I guess you know. That's much a corner case, I think it's not at all important.

[singalen]

Not so well done then :D It's rather a quick hack.
Thanks for feedback! Will work to improve it.

[ghost]

When the highlight is one hex below a village (so the number would be in the hex where the village is) the number is not showing.

[singalen]

Yep, it's broken under any animated hex, and under some others.
Plus, confusing in general.

I think this needs to be reverted and redone as a big tooltip. Not too easy, as current tooltips don't work well with touch interface.