Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASP.NET Core SignalR integration package #563

Closed
dotnetjunkie opened this issue Jun 7, 2018 · 1 comment
Closed

Add ASP.NET Core SignalR integration package #563

dotnetjunkie opened this issue Jun 7, 2018 · 1 comment
Labels

Comments

@dotnetjunkie
Copy link
Collaborator

See: #232 (comment)

This package should do the following:

  • Implement a SimpleInjectorHubActivator<T> class
  • Add an extension method for registration of this class
  • Add an extension method that allows auto-registration of Hub classes, similar to the RegisterMvcControllers of the ASP.NET Core MVC integration package. i.e. it should register Hub classes based on the selected lifestyle (ILifestyleSelectionBehavior) and should suppress the disposable transient components warning in case the Hub implementation does not override Dispose(bool).

Especially this last point is the main reason why we need an integration package. Integrating SignalR without an integration package would have been trivial in case Hub would not have implemented IDisposable (and it shouln't have).

@dotnetjunkie
Copy link
Collaborator Author

Won't fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant