Stop supporting deprecated syntax for config source expansion #5832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
fail-bare-env-vars
branch
from
00e2761 to
a619e6b
Compare
dmitryax
force-pushed
the
fail-bare-env-vars
branch
2 times, most recently
from
72b1093 to
3c6ad16
Compare
jinja2
reviewed
Jan 22, 2025
jinja2
reviewed
Jan 22, 2025
dmitryax
force-pushed
the
fail-bare-env-vars
branch
2 times, most recently
from
08de380 to
25a4692
Compare
jinja2
approved these changes
Jan 24, 2025
Expansion of bare config sources in the configuration is discontinued.
Strings like `$ENV` or `$include:/path/to/file.yaml` will no longer be expanded. Instead, use the `${env:ENV}` or `${include:/path/to/file.yaml}` syntax. There are only two symbols allowed after `$`: `{` and `$`. The collector will log an error and fail to start if it encounters a bare config source.
dmitryax
force-pushed
the
fail-bare-env-vars
branch
from
25a4692 to
4db461d
Compare
|
3 unrelated tests are still failing. Submitted separate PRs to fix them: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expansion of bare config sources is no longer supported.
Strings like
$ENVor$include:/path/to/file.yamlwill no longer be expanded. Instead, use the${env:ENV}or${include:/path/to/file.yaml}syntax. Only two symbols are allowed after$:{and$. The collector will log an error and fail to start if it encounters a bare config source expansion.This syntax has been deprecated since version 0.105.0.
The reason for this change is aligning with OpenTelemetry Collector upstream, where this syntax has been removed in 0.104.0 version. Long term plan is to do not have the custom config sources in this repository, instead consolidate the functionality with the upstream confmap providers.