Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Refresh the code to latest standards #157

Closed
AmitMY opened this issue May 20, 2024 · 2 comments
Closed

[Feature] Refresh the code to latest standards #157

AmitMY opened this issue May 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@AmitMY
Copy link
Contributor

AmitMY commented May 20, 2024 •
edited
Loading

Problem

Our serving quality had regressed as various libraries slowly introduced changes, and optimizations were not taken into account.

Description

  1. We should move the build system to esbuild (https://angular.io/guide/esbuild)
  2. To do that, we must move ionic to standalone (https://ionicframework.com/docs/angular/build-options#standalone)
  3. To do that, it would be easier to convert existing components to standalone
  4. Only then, we can perform prerendering again, and see that the app renders correctly without Javascript.
  5. Prerendering should then be done separately for mobile iOS, mobile Android, Desktop iOS and desktop Android, and served correctly based on headers from firebase.
  6. Once prerendering is good, we can leverage angular universal on firebase https://firebase.google.com/docs/hosting/frameworks/angular

Alternatives

No response

Additional context

No response
@AmitMY AmitMY added the enhancement New feature or request label May 20, 2024
AmitMY added a commit that referenced this issue May 20, 2024
@AmitMY
feat(ionic): start migrating to standalone components according to #157
4bcaf0c
AmitMY added a commit that referenced this issue Dec 14, 2024
@AmitMY
Upgrade codebase to Angular19 (#177)
8efd6f4 
* feat(ionic): start migrating to standalone components according to #157

* feat(angular19): start upgrade to angular 19

* feat(angular19): convert components to standalone

* feat(angular19): convert components to standalone

* fix(angular19): app runs!

* before migration

* chore(): run standalone component migration

* chore(): run inject migration

* fix(routes): use main component

* lint(): reformat files

* fix(): remove IonicModule completely

* chore(): update dependencies

* feat(settings): add settings page

* test(): fix standalone component tests

* feat(ng19): remove unused modules

* chore(): update dependencies

* feat(translate): add logo to translation page

* chore(): output signal migration

* chore(): update dependencies

* fix(tooltip): use module

* chore(): update dependencies

* chore(): update dependencies

* fix(icons): use self closing tags

* lint(): use prettier to reformat angular html files

* lint(): use prettier to reformat angular html files

* lint(): use prettier to reformat angular html files

* fix(dependencies): downgrade angular to compile

* fkx(icon): add missing icon

* chore(): update dependencies

* test(): remove failing tests
@AmitMY
Copy link
Contributor Author

AmitMY commented Dec 24, 2024

Now using vite, and converted all components to standalone 8efd6f4

@AmitMY
Copy link
Contributor Author

AmitMY commented Jan 21, 2025

We have pre-rendering, but still some issues with ionic - closing in favor of #194

@AmitMY AmitMY closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AmitMY