Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading builds is broken/weird #132

Open
michael-beaver opened this issue Mar 2, 2018 · 1 comment
Open

Downloading builds is broken/weird #132

michael-beaver opened this issue Mar 2, 2018 · 1 comment

Comments

@michael-beaver
Copy link
Contributor

Currently when you download a client build it seems that it is trying to download it as a gzip but when you try to extract, it has some weird responses. On my system if you click on it after downloading via chrome, it appears to download it again with the same name. If you try and extract via the command line, it yells and says that it is not a gzip, and if you try and open it with something like less or a text editor it appears that the file is corrupted at the end.

After downloading the file with the same address via wget it appears that it is a proper gzip, and extracting it seems to work fine, so I think this is an issue with how we are trying to get it through our site

@user404d
Copy link

user404d commented Mar 8, 2018

I think this was a bug on my end. I wasn't closing the stream I was writing to and so it would be left open and have garbage in it. Having said that, since I'm attaching headers which let the browser know that the file is a gzip it will be automatically decompressed when received by users. So renaming the file before it arrives might be a good idea? I don't know how that would work exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants