Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinch gesture not working #1

Closed
sidevesh opened this issue Apr 25, 2024 · 11 comments
Closed

Pinch gesture not working #1

sidevesh opened this issue Apr 25, 2024 · 11 comments

Comments

@sidevesh
Copy link
Owner

Originally reported at harshadgavali/gnome-gesture-improvements#206 (comment)

@trottdeaje
Copy link

I just wanted to express my interest in this bug fix. Unfortunately, I'm not very knowledgeable in this area, but I'd be happy to test it! Thanks for all you've done so far!

@FlynnD273
Copy link
Contributor

FlynnD273 commented May 24, 2024

Alright so I've done some digging and logging, and it seems that the extension is connecting to a signal from global.stage called captured-event::touchpad, in the code here. It's not even activating on a pinch gesture. However, it seems I'm able to perform the pinch gestures when the cursor is over a GNOME UI element, like the top bar. I have no idea why. This... seems like a GNOME issue and not an extension issue though. Everything else seems to be functioning properly.

@FlynnD273
Copy link
Contributor

Oh wait a second, the swipe and pinch trackers are two different things. So maybe if we could figure out the difference between the two?

@FlynnD273
Copy link
Contributor

I have submitted an issue here in the Mutter project, I did a little digging and I'm fairly certain this isn't an issue with this extension.

@Beast-Viper
Copy link

Any solution for this?

@FlynnD273
Copy link
Contributor

Any solution for this?

Not on this end, it appears to be a Mutter bug.

@mockballed
Copy link

Hopefully this will be addressed soon by the Mutter team. In the meanwhile: would it be feasible to assign the pinch gesture behaviour to another gesture? I would very much like to have a three finger swipe down gesture invoke the Ctrl+W shortcut.

I haven't taken a very close look at the code yet. Could someone point me in the right direction?

@FlynnD273
Copy link
Contributor

FlynnD273 commented Jun 1, 2024

Hopefully this will be addressed soon by the Mutter team. In the meanwhile: would it be feasible to assign the pinch gesture behaviour to another gesture? I would very much like to have a three finger swipe down gesture invoke the Ctrl+W shortcut.

I haven't taken a very close look at the code yet. Could someone point me in the right direction?

I'm sure it's possible! I think you should just be able to change this case with this._keyboard.sendKeys([Clutter.KEY_Control_L, Clutter.KEY_w]); from this line in the CloseWindow file. This is what sends the Ctrl+W shortcut.

For installing the extension, you should just be able to zip the gestureImprovements@gestures directory and run gnome-extensions install [email protected]. You might have to run glib-compile-schemas schemas/ before that to compile the schemas too though. I remember having issues with that when I was poking around trying to figure out why pinch gestures weren't working.

@mockballed
Copy link

Great! For anyone interested, replace lines 100, 101 and 102 here with
this._virtualDevice.sendKeys([Clutter.KEY_Control_L, Clutter.KEY_w]);

Much appreciated, @FlynnD273!

@Beast-Viper
Copy link

Great! For anyone interested, replace lines 100, 101 and 102 here with this._virtualDevice.sendKeys([Clutter.KEY_Control_L, Clutter.KEY_w]);

Much appreciated, @FlynnD273!

Hello, I tried your suggestion but it didn't work. Maybe I should set it to some other custom shortcut (Mine uses Meta + Q to exit app).

@sidevesh
Copy link
Owner Author

sidevesh commented Jul 1, 2024

Closing this as it is caused by mutter itself in latest GNOME release and I am getting no response on the issues I opened in GNOME GitLab

@sidevesh sidevesh closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants