From 067e5f60d7fb6ce9cdeb93663004ed9a233d17d5 Mon Sep 17 00:00:00 2001 From: Shramee Srivastav Date: Fri, 15 Mar 2024 15:52:34 +0530 Subject: [PATCH] cleanup --- corelib/Scarb.lock | 2 +- exercises/arrays/arrays3.cairo | 1 - exercises/dict/dict1.cairo | 3 +-- exercises/dict/dict2.cairo | 3 +-- exercises/dict/dict3.cairo | 11 +++-------- exercises/enums/enums1.cairo | 6 ++---- exercises/enums/enums3.cairo | 2 +- exercises/functions/functions3.cairo | 2 -- exercises/functions/functions4.cairo | 1 - exercises/if/if1.cairo | 1 - exercises/if/if2.cairo | 2 +- exercises/intro/intro2.cairo | 1 - exercises/loops/loops2.cairo | 2 +- exercises/modules/modules1.cairo | 1 - exercises/primitive_types/primitive_types1.cairo | 2 -- exercises/primitive_types/primitive_types2.cairo | 2 -- exercises/primitive_types/primitive_types3.cairo | 2 -- exercises/quizs/quizs1.cairo | 1 - exercises/starknet/basics/starknet4.cairo | 1 - exercises/structs/structs3.cairo | 2 +- exercises/traits/traits3.cairo | 1 - exercises/variables/variables1.cairo | 2 +- 22 files changed, 13 insertions(+), 38 deletions(-) diff --git a/corelib/Scarb.lock b/corelib/Scarb.lock index 0bd6895c9..18d39df00 100644 --- a/corelib/Scarb.lock +++ b/corelib/Scarb.lock @@ -3,4 +3,4 @@ version = 1 [[package]] name = "core" -version = "2.4.1" +version = "2.5.3" diff --git a/exercises/arrays/arrays3.cairo b/exercises/arrays/arrays3.cairo index 95975eaf3..5a66fe8fd 100644 --- a/exercises/arrays/arrays3.cairo +++ b/exercises/arrays/arrays3.cairo @@ -24,4 +24,3 @@ fn test_arrays3() { // You should not change the index accessed. a.at(2); } - \ No newline at end of file diff --git a/exercises/dict/dict1.cairo b/exercises/dict/dict1.cairo index de389fd96..31ee23581 100644 --- a/exercises/dict/dict1.cairo +++ b/exercises/dict/dict1.cairo @@ -10,10 +10,9 @@ // I AM NOT DONE - fn create_dictionary() -> Felt252Dict { let mut dict: Felt252Dict = Default::default(); - //TODO +//TODO } diff --git a/exercises/dict/dict2.cairo b/exercises/dict/dict2.cairo index 6a0025ab6..3f1469343 100644 --- a/exercises/dict/dict2.cairo +++ b/exercises/dict/dict2.cairo @@ -7,11 +7,10 @@ // I AM NOT DONE - fn multiply_element_by_10(ref dict: Felt252Dict, n: usize) { //TODO : make a function that multiplies the elements stored at the indexes 0 to n of a dictionary by 10 - + } // Don't change anything in the test diff --git a/exercises/dict/dict3.cairo b/exercises/dict/dict3.cairo index aef34eb29..5b6a0e30f 100644 --- a/exercises/dict/dict3.cairo +++ b/exercises/dict/dict3.cairo @@ -7,14 +7,12 @@ // Make me compile and pass the test! // Execute `starklings hint dict3` or use the `hint` watch subcommand for a hint. - // I AM NOT DONE - #[derive(Destruct)] struct Team { - level: Felt252Dict, - players_count: usize + level: Felt252Dict, + players_count: usize } #[generate_trait] @@ -41,11 +39,9 @@ impl TeamImpl of TeamTrait { } - #[test] #[available_gas(200000)] fn test_add_player() { - let mut team = TeamTrait::new(); team.add_player('bob', 10); team.add_player('alice', 20); @@ -58,9 +54,8 @@ fn test_add_player() { #[test] #[available_gas(200000)] fn test_level_up() { - let mut team = TeamTrait::new(); - team.add_player('bobby',10); + team.add_player('bobby', 10); team.level_up('bobby'); assert(team.level.get('bobby') == 11, 'Wrong level'); diff --git a/exercises/enums/enums1.cairo b/exercises/enums/enums1.cairo index da02ef0f0..93575091a 100644 --- a/exercises/enums/enums1.cairo +++ b/exercises/enums/enums1.cairo @@ -3,7 +3,6 @@ // I AM NOT DONE - use debug::PrintTrait; enum Message { // TODO: define a few types of messages as used below } @@ -18,9 +17,8 @@ fn main() { impl MessagePrintImpl of PrintTrait { fn print(self: Message) { match self { - - Message::Quit => println!("Quit"), - Message::Echo => println!("Echo"), + Message::Quit => println!("Quit"), + Message::Echo => println!("Echo"), Message::Move => println!("Move"), Message::ChangeColor => println!("ChangeColor") } diff --git a/exercises/enums/enums3.cairo b/exercises/enums/enums3.cairo index 93a66595d..78493fcf1 100644 --- a/exercises/enums/enums3.cairo +++ b/exercises/enums/enums3.cairo @@ -2,7 +2,7 @@ // Address all the TODOs to make the tests pass! // Execute `starklings hint enums3` or use the `hint` watch subcommand for a hint. -// I AM NOT DONE print +// I AM NOT DONE use debug::PrintTrait; diff --git a/exercises/functions/functions3.cairo b/exercises/functions/functions3.cairo index 27e152440..df0407dd4 100644 --- a/exercises/functions/functions3.cairo +++ b/exercises/functions/functions3.cairo @@ -3,12 +3,10 @@ // I AM NOT DONE - fn main() { call_me(); } fn call_me(num: u64) { - println!("num is {}", num); } diff --git a/exercises/functions/functions4.cairo b/exercises/functions/functions4.cairo index d69217a09..07df25646 100644 --- a/exercises/functions/functions4.cairo +++ b/exercises/functions/functions4.cairo @@ -9,7 +9,6 @@ // I AM NOT DONE - fn main() { let original_price = 51; println!("sale_price is {}", sale_price(original_price)); diff --git a/exercises/if/if1.cairo b/exercises/if/if1.cairo index 89329f05f..981f4a0a9 100644 --- a/exercises/if/if1.cairo +++ b/exercises/if/if1.cairo @@ -24,4 +24,3 @@ mod tests { assert(42 == bigger(32, 42), '42 bigger than 32'); } } - \ No newline at end of file diff --git a/exercises/if/if2.cairo b/exercises/if/if2.cairo index ab48caad2..151a493c3 100644 --- a/exercises/if/if2.cairo +++ b/exercises/if/if2.cairo @@ -38,4 +38,4 @@ mod tests { fn default_to_baz() { assert(foo_if_fizz('literally anything') == 'baz', 'anything else returns baz'); } -} +} diff --git a/exercises/intro/intro2.cairo b/exercises/intro/intro2.cairo index 799b5ddc3..29604faa8 100644 --- a/exercises/intro/intro2.cairo +++ b/exercises/intro/intro2.cairo @@ -2,4 +2,3 @@ // This exercise won't compile... Can you make it compile? -fn main(){} \ No newline at end of file diff --git a/exercises/loops/loops2.cairo b/exercises/loops/loops2.cairo index 2f6fbceab..5a4ba9435 100644 --- a/exercises/loops/loops2.cairo +++ b/exercises/loops/loops2.cairo @@ -16,4 +16,4 @@ fn test_loop() { }; assert(result == 5, 'result should be 5'); -} +} diff --git a/exercises/modules/modules1.cairo b/exercises/modules/modules1.cairo index 0772435f1..9cc95052d 100644 --- a/exercises/modules/modules1.cairo +++ b/exercises/modules/modules1.cairo @@ -28,4 +28,3 @@ mod tests { assert(order_result == 'order_taken', 'Order not taken'); } } - \ No newline at end of file diff --git a/exercises/primitive_types/primitive_types1.cairo b/exercises/primitive_types/primitive_types1.cairo index a57525063..248529e2e 100644 --- a/exercises/primitive_types/primitive_types1.cairo +++ b/exercises/primitive_types/primitive_types1.cairo @@ -4,8 +4,6 @@ // I AM NOT DONE - - fn main() { // Booleans (`bool`) diff --git a/exercises/primitive_types/primitive_types2.cairo b/exercises/primitive_types/primitive_types2.cairo index bc50468d7..6e91cadbf 100644 --- a/exercises/primitive_types/primitive_types2.cairo +++ b/exercises/primitive_types/primitive_types2.cairo @@ -4,8 +4,6 @@ // I AM NOT DONE - - fn main() { // A short string is a string whose length is at most 31 characters, and therefore can fit into a single field element. // Short strings are actually felts, they are not a real string. diff --git a/exercises/primitive_types/primitive_types3.cairo b/exercises/primitive_types/primitive_types3.cairo index 72e7312ae..1855afe97 100644 --- a/exercises/primitive_types/primitive_types3.cairo +++ b/exercises/primitive_types/primitive_types3.cairo @@ -4,8 +4,6 @@ // I AM NOT DONE - - fn main() { let cat = ('Furry McFurson', 3); let // your pattern here = cat; diff --git a/exercises/quizs/quizs1.cairo b/exercises/quizs/quizs1.cairo index 812d40377..1f26c3060 100644 --- a/exercises/quizs/quizs1.cairo +++ b/exercises/quizs/quizs1.cairo @@ -24,4 +24,3 @@ fn verify_test() { assert(82 == price3, 'Incorrect price'); assert(130 == price4, 'Incorrect price'); } - \ No newline at end of file diff --git a/exercises/starknet/basics/starknet4.cairo b/exercises/starknet/basics/starknet4.cairo index b59655992..35edd69b9 100644 --- a/exercises/starknet/basics/starknet4.cairo +++ b/exercises/starknet/basics/starknet4.cairo @@ -163,4 +163,3 @@ mod test { contract0 } } - \ No newline at end of file diff --git a/exercises/structs/structs3.cairo b/exercises/structs/structs3.cairo index 0642f109a..21d04b513 100644 --- a/exercises/structs/structs3.cairo +++ b/exercises/structs/structs3.cairo @@ -79,4 +79,4 @@ fn calculate_transport_fees() { assert(package.get_fees(cents_per_gram) == 4500, 'Wrong fees'); } - + diff --git a/exercises/traits/traits3.cairo b/exercises/traits/traits3.cairo index 648323aa4..6acf198d7 100644 --- a/exercises/traits/traits3.cairo +++ b/exercises/traits/traits3.cairo @@ -76,4 +76,3 @@ fn test_traits3() { assert(dog.make_noise() == 'woof', 'Wrong noise'); assert(dog.get_distance() == 1, 'Wrong distance'); } - diff --git a/exercises/variables/variables1.cairo b/exercises/variables/variables1.cairo index 47651ba59..fd8d596a2 100644 --- a/exercises/variables/variables1.cairo +++ b/exercises/variables/variables1.cairo @@ -2,7 +2,7 @@ // Make me compile! // Execute `starklings hint variables1` or use the `hint` watch subcommand for a hint. -// I AM NOT DONE +// I AM NOT DONE use debug::PrintTrait;