Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Earning power is close to type(uint96).max, any upscaling can brick functionality #41

Open
CergyK opened this issue Dec 7, 2024 · 2 comments
Open

Earning power is close to type(uint96).max, any upscaling can brick functionality #41

CergyK opened this issue Dec 7, 2024 · 2 comments
Labels
Low/Info A Low/Info severity issue.

Comments

@CergyK
Copy link
Collaborator

CergyK commented Dec 7, 2024

Description

Earning power is considered to be homogenous to governance token balances, and as such should be well within bounds of uint96. The provided calculator implementation BinaryEligibilityOracleEarningPowerCalculator returns at most the balance for a deposit. However the earning power should be able to reach type(uint96).max if new calculator implementations apply multipliers (in the magnitude of x1000) to a deposit balance.

Recommendation

Document this limitation/restriction for future calculator implementations.
@CergyK CergyK added the Low/Info A Low/Info severity issue. label Dec 7, 2024
@alexkeating alexkeating mentioned this issue Dec 11, 2024
Open
@alexkeating
Copy link

Will document

@CergyK
Copy link
Collaborator Author

CergyK commented Dec 16, 2024

Documented in withtally/staker#90

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Low/Info A Low/Info severity issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexkeating @CergyK