Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FonDevs - strict equality in SolidlyV2AMO will cause mintAndSellBoost to revert #334

Open
sherlock-admin3 opened this issue Oct 29, 2024 · 0 comments

Comments

@sherlock-admin3
Copy link

sherlock-admin3 commented Oct 29, 2024

FonDevs

Medium

strict equality in SolidlyV2AMO will cause mintAndSellBoost to revert

Summary

because of the strict equality check in usdAmountOut != usdBalanceAfter - usdBalanceBefore, _mintAndSellBoost might fail
https://github.com/sherlock-audit/2024-10-axion/blob/main/liquidity-amo/contracts/SolidlyV2AMO.sol#L187

Root Cause

there is strict equality check in usdAmountOut != usdBalanceAfter - usdBalanceBefore

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

No response

PoC

No response

Mitigation

No response

@sherlock-admin2 sherlock-admin2 changed the title Loud Beige Starfish - strict equality in SolidlyV2AMO will cause mintAndSellBoost to revert FonDevs - strict equality in SolidlyV2AMO will cause mintAndSellBoost to revert Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant