Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Stop unit tests making network requests #761

Open
0xdef1cafe opened this issue Jun 7, 2022 · 5 comments
Open

Stop unit tests making network requests #761

0xdef1cafe opened this issue Jun 7, 2022 · 5 comments
Assignees

Comments

@0xdef1cafe
Copy link
Collaborator

Overview

Unit tests are making network requests - failing tests below for reference

References and additional details

Acceptance Criteria

  • Fix the root cause and prevent unit tests from making network requests
  • Bonus points - stop tests logging from console to prevent spew

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

4 hours

@0xdef1cafe
Copy link
Collaborator Author

still valid but low priority

@MBMaria
Copy link

MBMaria commented Aug 2, 2022

@0xdef1cafe we have had a bounty hunter request to work on this as a bounty. Thoughts? https://app.dework.xyz/shapeshift-dao/shapeshift-bounties?taskId=50285c4b-e87f-4693-a63a-3cad768f1179

@0xdef1cafe
Copy link
Collaborator Author

@0xf11nix you keen for this buddy? low priority and no deadline

@0xf11nix
Copy link

0xf11nix commented Aug 4, 2022

@0xf11nix you keen for this buddy? low priority and no deadline

@0xdef1cafe Yeah mate, I've got this one.
Should be able to smash most of it out over the weekend, if that suits?

@brymut
Copy link
Contributor

brymut commented Oct 26, 2022

Hi @0xdef1cafe, might this still be relevant/available?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants