Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Remove patch from lib #139

Open
0xdef1cafe opened this issue Oct 19, 2021 · 6 comments
Open

Remove patch from lib #139

0xdef1cafe opened this issue Oct 19, 2021 · 6 comments
Labels
blocked

Comments

@0xdef1cafe
Copy link
Collaborator

https://github.com/shapeshift/lib/pull/136/files#diff-c3f51ca8777f4cc6e6128ef417f7c38d87662e7413cd8471dfc9237b5685beb4R1-R17

this is not production ready and isn't the solution. we need to fork this repo and fix it.
@0xean
Copy link
Contributor

0xean commented Dec 10, 2021 •
edited
Loading

@reidrankin - Can you please create a ticket in HD wallet to remove all bithighlander dependencies?

@mrnerdhair
Copy link
Contributor

Huh, I thought this was taken care of already. Looks like tendermint-tx-builder still has a transitive dep on an old version of his bitcoinjs fork, though. We'll need to fork that and update it.

@0xean
Copy link
Contributor

0xean commented Jan 28, 2022

assigned to @BitHighlander

@0xdef1cafe
Copy link
Collaborator Author

this will be addressed by the new https://github.com/shapeshift/tendermint-tx-builder repo

@0xdef1cafe 0xdef1cafe moved this to Backlog in ShapeShift Dashboard Feb 26, 2022
@mrnerdhair mrnerdhair mentioned this issue Mar 17, 2022
Open
@mrnerdhair
Copy link
Contributor

Blocked by shapeshift/hdwallet#409.

@mrnerdhair mrnerdhair moved this from Todo to Backlog in Security Dashboard Apr 2, 2022
@0xean
Copy link
Contributor

0xean commented Jun 15, 2022

@mrnerdhair - can you comment on if this ticket is still valid?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocked
Projects
ShapeShift Dashboard
Archived in project
Security Dashboard
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrnerdhair @0xean @0xdef1cafe