Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade syntax for React Router #157

Closed
samau3 opened this issue Nov 1, 2024 · 0 comments · Fixed by #174
Closed

Upgrade syntax for React Router #157

samau3 opened this issue Nov 1, 2024 · 0 comments · Fixed by #174
Assignees
@francisli

Comments

@samau3
Copy link
Contributor

samau3 commented Nov 1, 2024 •
edited by francisli
Loading

The syntax being used is the older version's approach, namely BrowserRouter. Instead there are newer approaches that support data API, such as createBrowserRouter:

https://reactrouter.com/6.28.0/routers/create-browser-router
@francisli francisli self-assigned this Dec 19, 2024
@francisli francisli linked a pull request Dec 20, 2024 that will close this issue
[Closes #157, Closes #162] Update client routing implementation #174
Merged
francisli added a commit that referenced this issue Dec 20, 2024
@francisli
[Closes #157, Closes #162] Update client routing implementation (#174)
9a15fd9 
* Clean out dead code

* Refactor Redirect component to separate file

* Refactor ProtectedRoute component into its own file

* First pass, rewriting route implementation- no auth/redirect handling yet

* Tweak sidebar a bit

* Tweak sidebar more

* New redirect/auth protection implementation

* Remove old code

* Restore loader while performing initial auth check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francisli francisli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Closes #157, Closes #162] Update client routing implementation sfbrigade/sf-lifeline
2 participants
@francisli @samau3