Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-hardcode Hero Appearance #251

Open
burner1024 opened this issue Jul 19, 2019 · 18 comments
Open

Un-hardcode Hero Appearance #251

burner1024 opened this issue Jul 19, 2019 · 18 comments

Comments

@burner1024
Copy link
Contributor

All the paths and names for this mod seem to be hardcoded in sfall. Would it be possible to un-hardcode, so that it could be packaged like a normal .dat?
Also, paths to msg files are the same, which makes it troublesome for hooking into translation system. If they included appearance name (text/english/game/apprace_hfr00s00.msg, for example), that would solve the problem.

@NovaRain
Copy link
Collaborator

Hero Appearance FRMs can be packed into individual .dat files.

@burner1024
Copy link
Contributor Author

You mean each one separately, or how does it work?
I simply moved "appearance" to data/ and the mod stopped working.

@NovaRain
Copy link
Collaborator

Each one separately in <GameRoot>\Appearance\. Here's the repack I made some time ago:
https://mega.nz/#!MBJDWQaZ!xJelF1dE2deSK7uoN8yO_aPF3rEpt_r6zPYMQbWB3i8

@burner1024
Copy link
Contributor Author

Oh, that's much better. Now if only I figure out a good way to handle translations...

@burner1024
Copy link
Contributor Author

burner1024 commented Jul 20, 2019

Edit: spoke too soon. Still, the mod can't be moved into mods dir, nor packaged as a single file.
And dat name regex seems to be hardcoded as well.

@NovaRain
Copy link
Collaborator

And dat name regex seems to be hardcoded as well.

Dat names are the same as dir names for the mod to sort race/style data, I guess what you're asking is close to overhaul the hero appearance mod.

@burner1024
Copy link
Contributor Author

Unhardcoding, overhauling - doesn't really matter how to call it, does it?

@FakelsHub
Copy link
Contributor

FakelsHub commented Aug 21, 2019

Ничего не планирую менять в системе внешности. Слишком мутный в нем код.

@FakelsHub
Copy link
Contributor

@burner1024 вроде как мод не может читать одновременно из .dat и из папки, да?

@burner1024
Copy link
Contributor Author

Не знаю, одновременно не пробовал.

@FakelsHub
Copy link
Contributor

FakelsHub commented Sep 27, 2019

Also, paths to msg files are the same, which makes it troublesome for hooking into translation system.

Сделал чтобы искало файлы одновреименно из папки и из dat как у Cratty.
Ты можешь упаковать frm изображения в соответствующие dat. без msg файлов,
А msg поместить в отдельные папки.

If they included appearance name (text/english/game/apprace_hfr00s00.msg, for example),

Могу предложить такой вид

AppStyleXX.msg
AppRaceXX.msg

Изменить название для самих .dat файлов нельзя, они подключаются при выборе соответствующего внешнего вида Героя.
Расположение менять думаю не имеет смысла.

NovaRain added a commit that referenced this issue Sep 28, 2019
* now it will search files in .dat files and folders simultaneously.

* files in folders have higher priority than .dat files.
@NovaRain
Copy link
Collaborator

For now the folder structure for a race/style can be:

|   HFR00S00.DAT
|   ...
|   HMR00S00.DAT
|   HMR00S01.DAT
|   ...
|
\---HMR00S01
    +---art
    |   \---skilldex
    |           AppStyle.FRM // if you want to override the one in .dat
    |
    \---text
        +---English
        |   \---Game
        |           AppStyle.msg
        \---German
            \---Game
                    AppStyle.msg

I think that should be enough to support installing multiple languages?

NovaRain added a commit that referenced this issue Sep 28, 2019
* now it will search files in .dat files and folders simultaneously.

* files in folders have higher priority than .dat files.
NovaRain added a commit that referenced this issue Sep 28, 2019
* now it will search files in .dat files and folders simultaneously.

* files in folders have higher priority than .dat files.
@burner1024
Copy link
Contributor Author

Изменить название для самих .dat файлов нельзя, они подключаются при выборе соответствующего внешнего вида Героя.

Да вроде и не надо менять?

Расположение менять думаю не имеет смысла.

Это менее удобно, но я думаю не критично.

I think that should be enough to support installing multiple languages?

Installing is not a problem, I think hero appearance ships with multiple languages since a long time ago?
Hooking it into translation system, however, requires that all files pertaining to a certain language reside in the same directory. And that is still not possible, as far as I can see.

@burner1024
Copy link
Contributor Author

On the same note, what path should be used with fs_copy for, say, appearance\hfr00s03\art\critters\_hfmaxxat.frm? I can't find the correct one.

@FakelsHub
Copy link
Contributor

по идеи точно без appearance\hfr00s03
Но это может физически не работать.

@burner1024
Copy link
Contributor Author

Тоже не работает. Непонятно, когда подмена происходит. Ну в общем это не так критично, у этих frm и так fps достаточно высокий.

burner1024 added a commit to BGforgeNet/FO2tweaks that referenced this issue Oct 6, 2019
@FakelsHub
Copy link
Contributor

FakelsHub commented Oct 8, 2019

Непонятно, когда подмена происходит.

путь к папке подключается динамически, уже после того как выполнена функция скопировать файл, т.е. такого файла еще не существует.
Хотя, а что возвращают функции fs_copy и fs_find -1 ?

@burner1024
Copy link
Contributor Author

Да, -1. fs_copy по крайней мере, fs_find не проверял.
В общем, если в стандартный мод не будет переделки, то конкретно с fs_ функциями возиться нет я думаю.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants