Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a solana_transaction_status::TransactionStatusMeta field to carbon_core::transaction::TransactionMetadata #86

Closed
KellianDev opened this issue Nov 19, 2024 · 2 comments · Fixed by #92
Closed

Add a solana_transaction_status::TransactionStatusMeta field to carbon_core::transaction::TransactionMetadata #86

KellianDev opened this issue Nov 19, 2024 · 2 comments · Fixed by #92
Assignees
@KellianDev
Labels
core A feature/improvement on the core crates. enhancement New feature or request

Comments

@KellianDev
Copy link
Contributor

KellianDev commented Nov 19, 2024 •
edited
Loading

We have access to that field on TransactionUpdate already from the datasource, so it is a low-hanging fruit to provide more context to processors.

For more context, here's the data inside that type:

#[derive(Clone, Debug, PartialEq)]
pub struct TransactionStatusMeta {
    pub status: TransactionResult<()>,
    pub fee: u64,
    pub pre_balances: Vec<u64>,
    pub post_balances: Vec<u64>,
    pub inner_instructions: Option<Vec<InnerInstructions>>,
    pub log_messages: Option<Vec<String>>,
    pub pre_token_balances: Option<Vec<TransactionTokenBalance>>,
    pub post_token_balances: Option<Vec<TransactionTokenBalance>>,
    pub rewards: Option<Rewards>,
    pub loaded_addresses: LoadedAddresses,
    pub return_data: Option<TransactionReturnData>,
    pub compute_units_consumed: Option<u64>,
}
@KellianDev
Copy link
Contributor Author

@unbound26z let me know what you think

@KellianDev KellianDev added enhancement New feature or request core A feature/improvement on the core crates. labels Nov 19, 2024
@KellianDev KellianDev self-assigned this Nov 19, 2024
@unbound26z
Copy link
Contributor

Exactly what we would need

@KellianDev KellianDev linked a pull request Nov 20, 2024 that will close this issue
feat(carbon-core): add a solana_transaction_status::TransactionStatus… #92
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KellianDev KellianDev

Labels
core A feature/improvement on the core crates. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(carbon-core): add a solana_transaction_status::TransactionStatus… sevenlabs-hq/carbon
2 participants
@unbound26z @KellianDev