Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --default-path command-line option #13

Open
cesarizu opened this issue May 24, 2021 · 3 comments
Open

Support --default-path command-line option #13

cesarizu opened this issue May 24, 2021 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@cesarizu
Copy link

rspec and parallel_tests support the --default-path option. This is useful, for example, when running specs inside an engine where one would define that as the default path.

Maybe unknown command-line options should be passed directly to parallel_rspec to avoid having to define each possible one?

@ilyazub
Copy link
Collaborator

ilyazub commented May 26, 2021

Maybe unknown command-line options should be passed directly to parallel_rspec to avoid having to define each possible one?

I like that idea but currently unknown options are treated as spec files (source). I'll think about a way to implement it.

files: @argv.empty? ? ["spec"] : @argv,

@ilyazub ilyazub added enhancement New feature or request question Further information is requested labels May 26, 2021
@cesarizu
Copy link
Author

A few options:

  • Some commands (like with git for example) treat everything after an isolated double dash (--) as file parameters, ej: git checkout -- somefile
  • Treat anything that starts with a dash or double dash as an option that needs to be passed to parallel_rspec
  • Check if the argument is indeed a file or a glob and treat as file

@ilyazub
Copy link
Collaborator

ilyazub commented May 27, 2021

Thanks for ideas 👍 Btw, turbo_tests executes RSpec directly instead. parallel_spec is used to group spec files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants