Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading output text in the check-kube-service-available.rb check #89

Open
jakerobb opened this issue Sep 12, 2019 · 0 comments
Open

Comments

@jakerobb
Copy link

jakerobb commented Sep 12, 2019

If a checked service is not ready for longer than the allowable pending seconds, the resulting critical message reads:

All services are not ready: (list of services here)

This is misleading. It sounds like ALL services are not ready; i.e., nothing is ready. A catastrophic failure.

This should instead read:

Not all services are ready: (list of services)

or

Some services are not ready: (list of services)

or, depending on the count:

(name of service) service is not ready.
(number) services are not ready: (list of services)

Feedback appreciated on which would be preferred; I like the last one best, myself. I'll give it a few days to gather opinions on that and then submit a PR if someone else doesn't beat me to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant