Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package test requirements #11

Open
MatthewPikar opened this issue Dec 19, 2015 · 1 comment
Open

package test requirements #11

MatthewPikar opened this issue Dec 19, 2015 · 1 comment

Comments

@MatthewPikar
Copy link

I fixed a bug which made delete crash when requested entities do not exist. Specifically I added a test to see if store.list returns any elements before heel is called.:

if(elements.length === 0) return cb(null, null);

store.list(args, function(err, elements) {
    if(elements.length === 0) return cb(null, null);
    var redisArgs = _.pluck(elements, 'id');

    redisArgs.unshift(table);

    dbConn.hdel(redisArgs, function(err, result) {
        if (!error(args, err, cb)) {
            cb(null, [result]);
        }
    });
});

I was about to make a pull request, but then I noticed that the test script is expecting seneca.test.store.shared and I don't want to submit anything without running the tests first. Where does that come from and how should I add it? Are there other dependencies I need to fulfill?

@mihaidma
Copy link
Collaborator

@MatthewPikar the shared tests are here: https://github.com/senecajs/seneca-store-test
Please PR against that repo.
I opened also an issue there: senecajs/seneca-store-test#38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants