Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve job events filtering #77

Open
jojedev opened this issue Nov 26, 2024 · 7 comments
Open

Improve job events filtering #77

jojedev opened this issue Nov 26, 2024 · 7 comments
Assignees

Comments

@jojedev
Copy link
Collaborator

jojedev commented Nov 26, 2024

We need to filter our events in order to get:

  • Multiple applicants messages working
  • Display all the neccesary job events that doesn't have a recipient address once a job has started and messages events.
  • Make sure that those events doesn't get displayed if the job state comes back to OPEN and owner decides to change workers.
  • Use index, so let's say a jop was assigned to pat. we'll get all the events from that event till pat is no longer being part of the job

\src\app\dashboard\jobs[id]\page.tsx On line 207.

little example:
image

I'll work on this later

@jojedev
Copy link
Collaborator Author

jojedev commented Nov 28, 2024

dade3f0

@jojedev
Copy link
Collaborator Author

jojedev commented Nov 28, 2024

@kasumi-1 Basically now we have the same functionality as before for a job that is open and has multiple applicants, but now if its taken it will find the last worker assign event and show you all the events from that point on, till it finds another job assign, if it does it will do the same.

@jojedev
Copy link
Collaborator Author

jojedev commented Nov 28, 2024

Pat suggested a collapsible to show all the previous events, but when I spoke with Tomas (some time ago) about that he told me that we wouldn't show all the past events. Would like your opinion on this

@jojedev
Copy link
Collaborator Author

jojedev commented Nov 29, 2024

I spoke this with Tomas and told me that for now isn't neccesary to work further on this and I think it makes sense, will close this

@jojedev jojedev closed this as completed Nov 29, 2024
@kasumi-1 kasumi-1 reopened this Nov 29, 2024
@kasumi-1
Copy link
Contributor

so if a worker delivers a result to a client, then they start a new job, how does the client then see the past deliverables?

i think its impossible to make the history inaccessible without causing many similar problems. i prefer being able to look at my past history, esp with many recurring jobs with same workers.

@kasumi-1
Copy link
Contributor

i think impl of #89 may do some of the heavy lifting here

@jojedev
Copy link
Collaborator Author

jojedev commented Jan 3, 2025

@kasumi-1 would you please provide more information about what is required here? I'm a bit confused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants