Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address all MSVC compilation warnings #1397

Open
tigercosmos opened this issue May 12, 2024 · 1 comment
Open

Address all MSVC compilation warnings #1397

tigercosmos opened this issue May 12, 2024 · 1 comment
Labels
build any build issue good first issue help wanted Windows

Comments

@tigercosmos
Copy link
Collaborator

There are many compilation warnings on MSVC. We should address all warnings first and then add the flag to disable warnings.
This was referenced May 12, 2024
Closed
Closed
@PeterJeff
Copy link

Shouldn't it be "and then add the flag to turn those warnings into hard errors" so people don't re-add problems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build any build issue good first issue help wanted Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tigercosmos @PeterJeff