From c862810e97bbb3ca002f48be77a2030c72267bd6 Mon Sep 17 00:00:00 2001 From: anjula-sack Date: Mon, 20 Jan 2025 22:34:29 +0530 Subject: [PATCH 1/4] Remove unused error value --- .../MentorRegistration/MentorRegistration.component.tsx | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/pages/MentorRegistration/MentorRegistration.component.tsx b/src/pages/MentorRegistration/MentorRegistration.component.tsx index 1d41b94..967dc26 100644 --- a/src/pages/MentorRegistration/MentorRegistration.component.tsx +++ b/src/pages/MentorRegistration/MentorRegistration.component.tsx @@ -64,11 +64,7 @@ const MentorRegistrationPage: React.FC = () => { error: categoriesError, } = useCategories(); - const { - data: allCountries, - isLoading: countriesLoading, - error: countriesError, - } = useCountries(); + const { data: allCountries, isLoading: countriesLoading } = useCountries(); const { createMentorApplication, From 5e0b70ecfd1a4259bbf505fe10fea1d32db186f8 Mon Sep 17 00:00:00 2001 From: anjula-sack Date: Mon, 20 Jan 2025 22:38:23 +0530 Subject: [PATCH 2/4] Update the ci yml --- .github/workflows/e2e.yml | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index a905b8d..6020e78 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -13,19 +13,19 @@ jobs: timeout-minutes: 60 runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 - with: - node-version: 18 - - name: Install dependencies - run: npm ci - - name: Install Playwright Browsers - run: npx playwright install --with-deps - - name: Run Playwright tests - run: npx playwright test - - uses: actions/upload-artifact@v3 - if: always() - with: - name: playwright-report - path: playwright-report/ - retention-days: 30 + - uses: actions/checkout@v3 + - uses: actions/setup-node@v3 + with: + node-version: 18 + - name: Install dependencies + run: npm ci + - name: Install Playwright Browsers + run: npx playwright@next install + - name: Run Playwright tests + run: npx playwright test + - uses: actions/upload-artifact@v3 + if: always() + with: + name: playwright-report + path: playwright-report/ + retention-days: 30 From 703fd4127828d07ab0c93ea4aac8774d1eb5acfc Mon Sep 17 00:00:00 2001 From: anjula-sack Date: Mon, 20 Jan 2025 22:42:02 +0530 Subject: [PATCH 3/4] Remove example tests --- tests/example.spec.ts | 18 ------------------ 1 file changed, 18 deletions(-) delete mode 100644 tests/example.spec.ts diff --git a/tests/example.spec.ts b/tests/example.spec.ts deleted file mode 100644 index c511525..0000000 --- a/tests/example.spec.ts +++ /dev/null @@ -1,18 +0,0 @@ -import { test, expect } from '@playwright/test'; - -test('has title', async ({ page }) => { - await page.goto('https://playwright.dev/'); - - // Expect a title "to contain" a substring. - await expect(page).toHaveTitle(/Playwright/); -}); - -test('get started link', async ({ page }) => { - await page.goto('https://playwright.dev/'); - - // Click the get started link. - await page.getByRole('link', { name: 'Get started' }).click(); - - // Expects the URL to contain intro. - await expect(page).toHaveURL(/.*intro/); -}); From acaa762a4fc4808976cb5bc9a43c9fbb6bdc2e7d Mon Sep 17 00:00:00 2001 From: anjula-sack Date: Mon, 20 Jan 2025 22:46:57 +0530 Subject: [PATCH 4/4] Remove E2E test workflow --- .github/workflows/e2e.yml | 31 ------------------------------- 1 file changed, 31 deletions(-) delete mode 100644 .github/workflows/e2e.yml diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml deleted file mode 100644 index 6020e78..0000000 --- a/.github/workflows/e2e.yml +++ /dev/null @@ -1,31 +0,0 @@ -name: E2E Tests -on: - push: - branches: - - main - - development - pull_request: - branches: - - main - - development -jobs: - test: - timeout-minutes: 60 - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 - with: - node-version: 18 - - name: Install dependencies - run: npm ci - - name: Install Playwright Browsers - run: npx playwright@next install - - name: Run Playwright tests - run: npx playwright test - - uses: actions/upload-artifact@v3 - if: always() - with: - name: playwright-report - path: playwright-report/ - retention-days: 30