KendoCultureHeaderItem / please extend from OnDomReadyHeaderItem

[Patrick1701]

Hi Sebastien,
I found a minor bug in KendoCultureHeaderItem.

Currently, developer must pay attention for order, in which HeaderItems be added to pages (when adding manually, not via KendoCultureHeaderContributor).

(My case is, I splitted KendoUI Framework Components in seperate JS files for file size delivery reasons and I'm adding e.g. Scheduler JS files on my own)

The culture setting script must be executed later to work correct in conjunction with other kendo component scripts on page.
I think OnDomReady is the prefered way.
(have a copied working class on our project until this issue is solved)

This change could also change the KendoCultureHeaderContributor. I used PrioritiyHeaderItem for some reason. I dont really remember... I believe it was just convenience-copy-paste, because I found some some parts in your JQueryBehaviors, where you wrap scripts on page using a PriorityHeaderItem.

But I'm not able to reappraise side-effects, when just removing PrioritiyHeaderItem in KendoCultureHeaderContributor, because you had reasons wrapping them in your JQueryBehaviors.
Could you please have a look on this?

kind regards
Patrick

[sebfz1]

Hi Patrick, I will have a look early in november... (currently in vacations ;) ) Best regards, Sebastien

[sebfz1]

Hi Patrick,

The culture setting script must be executed later to work correct in conjunction with other kendo component scripts on page.

Hummm, I do not really agree. At least that's not what I remember. Moreover, it seems to late (to me) to execute the culture statement (kendo.culture('de_DE')) in the dom ready script. I need to investigate much more...

where you wrap scripts on page using a PriorityHeaderItem.

PriorityHeaderItem is highly recommended if the underlying HeaderItem directly relies on a script file. If not, there is a chance that the script is attached after a statement that would use it (in a renderHead, from a page, component or a behavior, the order of attachments to the DOM may differs...).