Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop logic for peer_cidr_blocks autocalculation #139

Open
dkropachev opened this issue Mar 27, 2024 · 0 comments
Open

Drop logic for peer_cidr_blocks autocalculation #139

dkropachev opened this issue Mar 27, 2024 · 0 comments

Comments

@dkropachev
Copy link
Contributor

dkropachev commented Mar 27, 2024

Currently we construct Meta.GCPBlocks from blocks.txt that we took from https://cloud.google.com/vpc/docs/subnets#ip-ranges
And use this region/cidr mapping for calculating default CIDR for GCP VPC Peering.

Idea is to drop this logic entirely and force client provide CIDR.

There is one case that is going to be broken with this change, is when GCP VPC is created with auto_create_subnetworks:

resource "google_compute_network" "app" {
	name = "app"
	auto_create_subnetworks = true
}

It is broken due to absence of google_compute_subnetwork in the state and inability to import these resources automatically, which should be handled by GCP terraform provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant