Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs - remove Advisor docs #2439

Closed
mykaul opened this issue Dec 30, 2024 · 4 comments · Fixed by #2457
Closed

Docs - remove Advisor docs #2439

mykaul opened this issue Dec 30, 2024 · 4 comments · Fixed by #2457
Labels
documentation Documentation related
Milestone
Monitoring 4.9

Comments

@mykaul
Copy link
Contributor

mykaul commented Dec 30, 2024

https://monitoring.docs.scylladb.com/stable/use-monitoring/advisor/index.html - but the advisor is gone already?
@mykaul mykaul added the documentation Documentation related label Dec 30, 2024
@tzach
Copy link
Contributor

tzach commented Dec 30, 2024

The table is gone, but AFAIU, the Advisor "advises" are still available
#2167

@amnonh
Copy link
Collaborator

amnonh commented Dec 31, 2024

@tzach is correct; more so, the advisor alerts will be shown as part of the alert tabel

@amnonh
Copy link
Collaborator

amnonh commented Dec 31, 2024

Closing as not planed. please reopen if you think it's needed

@amnonh amnonh closed this as completed Dec 31, 2024
@tzach
Copy link
Contributor

tzach commented Jan 1, 2025

@amnonh the doc still refere to an Advisor section we need to fix this.

@tzach tzach reopened this Jan 1, 2025
@amnonh amnonh added this to the Monitoring 4.9 milestone Jan 7, 2025
amnonh added a commit to amnonh/scylla-grafana-monitoring that referenced this issue Jan 12, 2025
@amnonh
docs/advisor remove the advisor section
678b524 
This patch removes the reference to the advisor section that was removed
from the dashboard, while keeping the advisor section that is still
part of the monitoring.

Fixes scylladb#2439
@amnonh amnonh mentioned this issue Jan 12, 2025
Merged
@amnonh amnonh closed this as completed in fae6b4f Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation related
Projects
None yet
Milestone
Monitoring 4.9
Development

Successfully merging a pull request may close this issue.

docs/advisor remove the advisor section amnonh/scylla-grafana-monitoring
3 participants
@tzach @amnonh @mykaul