Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyspace dashboard] Allow selecting multiple tables #2363

Open
hopugop opened this issue Jul 17, 2024 · 5 comments
Open

[Keyspace dashboard] Allow selecting multiple tables #2363

hopugop opened this issue Jul 17, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@hopugop
Copy link
Contributor

hopugop commented Jul 17, 2024

Describe the feature and the current behavior/state.
Table metrics are amazing. However, it only allows to choose from a single table at a time. It would be really useful to allow a view for all tables in a single view - think of it like a historical view of tables' operations, latency and dataset.

I recently used raw queries to achieve this, such as sum(scylla_column_family_total_disk_space{}) by(dc,ks,table) to aggregate disk utilization by table. There might be many others beneficial uses.

Who will benefit with this feature?
Anyone that is interested in historical metrics comparison for multiple tables.

image

@hopugop hopugop added the enhancement New feature or request label Jul 17, 2024
@mykaul
Copy link
Contributor

mykaul commented Jul 21, 2024

It makes sense to aggregate (sum? avg?) specific data from multiple tables - such as disk space. What else? Latency or ops make little sense to me.

@amnonh amnonh added this to the Monitoring 4.9 milestone Dec 11, 2024
@amnonh
Copy link
Collaborator

amnonh commented Jan 5, 2025

@mykaul @hopugop The title is confusing; in your graph, you do not aggregate; you show a line per table. So yes, technically, we can allow choosing multiple key spaces.

The table's drop-down menu will be more confusing when picking multiple keys paces.

@mykaul
Copy link
Contributor

mykaul commented Jan 5, 2025

@mykaul @hopugop The title is confusing; in your graph, you do not aggregate; you show a line per table. So yes, technically, we can allow choosing multiple key spaces.

The table's drop-down menu will be more confusing when picking multiple keys paces.

I think aggregate is used in a confusing manner here - the intent is 'bring multiple data from multiple tables into a single view' - not an aggregate of 'sum the multiple data from multiple tables and display it' - but I may be wrong. I referred to the latter, but I think the original author referred to the former defintion.

@hopugop hopugop changed the title Show aggregate table metrics per cluster [Keyspace dashboard] Allow selecting multiple tables Jan 6, 2025
@hopugop
Copy link
Contributor Author

hopugop commented Jan 6, 2025

'bring multiple data from multiple tables into a single view' - not an aggregate of 'sum the multiple data from multiple tables and display it'

That's correct. I updated the issue title to match it.

@amnonh
Copy link
Collaborator

amnonh commented Jan 6, 2025

@hopugop We already support multiple tables, the limitation we have is allowing multiple keyspaces

@amnonh amnonh modified the milestones: Monitoring 4.9, Monitoring 5.0 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants