Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(managerclient): adds new task type - 1_1_restore #4219

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(managerclient): adds new task type - 1_1_restore #4219

wants to merge 2 commits into from

Conversation

VAveryanov8
Copy link
Collaborator

@VAveryanov8 VAveryanov8 commented Jan 20, 2025 •
edited
Loading

This adds a new task type for 1-1 vnode restore.
As managerclient is a separate go module, changes into it should be merged first.

Fixes: #4200

Please make sure that:

  • Code is split to commits that address a single change
  • Commit messages are informative
  • Commit titles have module prefix
  • Commit titles have issue nr. suffix

@VAveryanov8
feat(managerclient): adds new task type - fastrestore
d9a5fbf 
This adds a new task type for fast vnode restore.

Fixes: #4200
@VAveryanov8 VAveryanov8 marked this pull request as ready for review January 20, 2025 11:55
@Michal-Leszczynski
Copy link
Collaborator

I really need to fix #4121..........
But anyway, I would call this task 121restore or topologyrestore or clonerestore something in this direction.
fastrestore just does not tell the whole story and the possible limitations.

@Michal-Leszczynski
Copy link
Collaborator

Also, just another idea in terms of #4200.
I don't really like a completely separate command for this restore type, but I get that adding flags to the current restore task might be messy. Can't we just make it a sub-command of the restore task (similar to sctool backup validate)?
Then, scheduling 121restore would look like sctool restore one2one or something similar.
This makes more sense to me, as why would we completely separate those two restore types?
The code can still be separated according to ones needs, it's just about the command layout.

What do you think @karol-kokoszka @VAveryanov8?

@karol-kokoszka
Copy link
Collaborator

Let's leave the discussion if we introduce new CLI to the Wednesday planning. It can be quickly changed.

@karol-kokoszka
Copy link
Collaborator

Let's name it "1-1-restore" for now.
Please check if it can be defined as a sub-command for "restore".

@VAveryanov8 VAveryanov8 force-pushed the va/fast-restore-part-1 branch from c2e40f6 to 39aa5f8 Compare January 23, 2025 14:17
@VAveryanov8 VAveryanov8 changed the title feat(managerclient): adds new task type - fastrestore feat(managerclient): adds new task type - 1_1_restore Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karol-kokoszka karol-kokoszka Awaiting requested review from karol-kokoszka karol-kokoszka is a code owner

@Michal-Leszczynski Michal-Leszczynski Awaiting requested review from Michal-Leszczynski Michal-Leszczynski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create service and CLI stub for fast vnodes restore.
3 participants
@VAveryanov8 @Michal-Leszczynski @karol-kokoszka