Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic SUT selection for graphs is not working properly #550

Open
soyacz opened this issue Dec 19, 2024 · 2 comments · May be fixed by #572
Open

Automatic SUT selection for graphs is not working properly #550

soyacz opened this issue Dec 19, 2024 · 2 comments · May be fixed by #572
Assignees
@soyacz

Comments

@soyacz
Copy link
Collaborator

soyacz commented Dec 19, 2024

There are cases (e.g. https://argus.scylladb.com/test_runs?state=WyI5YzUzYTc5NS0zODFiLTQ4ZWQtOTYwYS02ZDE4NGRhY2FiYTciXQ) where SUT is not chosen properly (selects kernel instead of Scylla).
Add ability to manualy select SUT package name (and save it for the future)
@soyacz soyacz self-assigned this Dec 19, 2024
soyacz added a commit to soyacz/argus that referenced this issue Dec 20, 2024
@soyacz
fix(graphs): automatic SUT issue workaround
7147654 
Before implementing proper fix with ability to SUT package for graphs,
introducing quick issue workaround to enable work with some tests.

refs: scylladb#550
@soyacz
Copy link
Collaborator Author

soyacz commented Dec 20, 2024

@fruch I implemented quick workaround so mentioned graphs work (without breaking SM graphs).
In future will be easy to extend it for driver tests in case it was needed.
In the meantime, after implementing #551 we should have full solution.
Can we close this one in favor of #551?

@soyacz
Copy link
Collaborator Author

soyacz commented Dec 20, 2024

btw. it's on staging for testing

@soyacz soyacz mentioned this issue Dec 20, 2024
Merged
soyacz added a commit that referenced this issue Dec 23, 2024
@soyacz
fix(graphs): automatic SUT issue workaround
df7aabf 
Before implementing proper fix with ability to SUT package for graphs,
introducing quick issue workaround to enable work with some tests.

refs: #550
soyacz added a commit to soyacz/argus that referenced this issue Jan 17, 2025
@soyacz
improvement(results): allow manual sut selection
31a3f9a 
In some cases it will be hard to automatically select proper SUT -
test that runs for the first time, or not supported package name by
automatic sut selection.

Allowed client (tests) to specify 'sut_package_name' - bypassing
automatic selection.

fixes: scylladb#550
@soyacz soyacz linked a pull request Jan 17, 2025 that will close this issue
Open
soyacz added a commit to soyacz/argus that referenced this issue Jan 17, 2025
@soyacz
improvement(results): allow manual sut selection
f9d2d83 
In some cases it will be hard to automatically select proper SUT -
test that runs for the first time, or not supported package name by
automatic sut selection.

Allowed client (tests) to specify 'sut_package_name' - bypassing
automatic selection.

fixes: scylladb#550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soyacz soyacz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvement(results): allow manual sut selection soyacz/argus
1 participant
@soyacz