Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate websocket library #817

Open
2 tasks
haerdib opened this issue Jan 23, 2025 · 1 comment
Open
2 tasks

Deprecate websocket library #817

haerdib opened this issue Jan 23, 2025 · 1 comment

Comments

@haerdib
Copy link
Contributor

haerdib commented Jan 23, 2025

ws-rs has not been updated for years and is now breaking the build on ubuntu-latest. As we have sufficient other websocket libraries (tungstenite and jsonrpsee), I suggest to deprecated the ws part, remove it from CI and later on remove it from the code completely.

Failing build: https://github.com/scs/substrate-api-client/actions/runs/12919440595/job/36029972296
Successful build, after downgrading Ubuntu: https://github.com/scs/substrate-api-client/actions/runs/12924234972/job/36042899472?pr=813

To solve this issue:

  • Mark Wsclient library as deprecated
  • Remove ws client example
@Niederb
Copy link
Contributor

Niederb commented Jan 23, 2025

Yes, this library has not been updated in a long time.... Given that using another client is easy I think we can deprecate it 👍

This was referenced Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants