Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ForEach extension method? #168

Open
jbagley-iona opened this issue Jan 31, 2022 · 2 comments
Open

ForEach extension method? #168

jbagley-iona opened this issue Jan 31, 2022 · 2 comments
Assignees
@StefH

Comments

@jbagley-iona
Copy link

The ForEach extension method recently added to LinqKit conflicts with the (I think) commonly used ForEach extension method in MoreLinq. Since it is in the main LinqKit namespace, there is no way to avoid its inclusion when using LinqKit. It would be nice if this was in a separate namespace to avoid this issue.
@StefH
Copy link
Collaborator

StefH commented Oct 23, 2022

@jbagley-iona

The namespace is LinqKit.Core or LinqKit, so how does that cause troubles when using MoreLinq?

@StefH StefH self-assigned this Oct 23, 2022
@n0099
Copy link

n0099 commented May 4, 2023 •
edited
Loading

It should put in a private static class to prevent anyone outside LINQKit can touch it.

n0099 added a commit to n0099/open-tbm that referenced this issue May 4, 2023
@n0099
- method ForEach() since it's conflicting with LinqKit: scottksmith…
0556b5a 
…95/LINQKit#168

- remove unused method `GetValuesByKeys()`
* move method `NanToZero()` and `RoundToUshort()` to project `tbm.Shared` since they are also used by project `tbm.ImagePipeline`
@ crawler/ExtensionMethods.cs

* remove the value to argument `cacheCapacity` of method `PaddleDevice.Mkldnn()` since it's now the default value: sdcb/PaddleSharp#46 @ `PaddleOcrRecognizerAndDetector.GetPaddleOcrFactory()`
* update NuGet packages
@ imagePipeline
@ c#
n0099 added a commit to n0099/open-tbm that referenced this issue May 30, 2023
@n0099
* reuse duplicate using directives across files into `GlobalUsings.…
e7ad061 
…cs`, except `using LinqKit;` due to scottksmith95/LINQKit#168 @ c#
n0099 added a commit to n0099/open-tbm that referenced this issue May 30, 2023
@n0099
* reuse duplicate using directives across files into `GlobalUsings.…
41c5eae 
…cs`, except `using LinqKit;` due to scottksmith95/LINQKit#168 @ c#
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefH StefH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StefH @jbagley-iona @n0099